Commit 0638eac0 authored by David Maus's avatar David Maus
Browse files

Don't suppress error messages

* src/HAB/Pica/Auth/LBSAuthentication.php (parseResponseBody): Do not
  suppress errors.
* src/HAB/Pica/Auth/AbstractHttpAuthentication.php (sendRequest): Do not
  suppress errors.
parent 381232cc
...@@ -53,7 +53,7 @@ abstract class AbstractHttpAuthentication ...@@ -53,7 +53,7 @@ abstract class AbstractHttpAuthentication
) )
); );
$ctx = stream_context_create($ctxOptions); $ctx = stream_context_create($ctxOptions);
$response = @file_get_contents($url, false, $ctx); $response = file_get_contents($url, false, $ctx);
if ($response === false) { if ($response === false) {
throw new RuntimeException("Error sending HTTP '{$method}' request to '{$url}'"); throw new RuntimeException("Error sending HTTP '{$method}' request to '{$url}'");
} }
......
...@@ -97,7 +97,7 @@ class LBSAuthentication extends AbstractHttpAuthentication implements Authentica ...@@ -97,7 +97,7 @@ class LBSAuthentication extends AbstractHttpAuthentication implements Authentica
*/ */
private function parseResponseBody ($body) private function parseResponseBody ($body)
{ {
$response = @simplexml_load_string($body); $response = simplexml_load_string($body);
if ($response === false || $response->getName() !== 'AuthenticationResponse' || (string)$response->status !== 'OK') { if ($response === false || $response->getName() !== 'AuthenticationResponse' || (string)$response->status !== 'OK') {
return false; return false;
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment