From f670b474555b69b70d4b71d0f6fb7a065ff24987 Mon Sep 17 00:00:00 2001
From: David Maus <maus@hab.de>
Date: Sat, 23 Jul 2016 11:20:26 +0200
Subject: [PATCH] Factor out subfield code pattern
* src/HAB/Pica/Record/Subfield.php ($validSubfieldCodePattern): New property.
(isValidSubfieldCode): Factor out subfield code pattern.
---
src/HAB/Pica/Record/Subfield.php | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/HAB/Pica/Record/Subfield.php b/src/HAB/Pica/Record/Subfield.php
index 9edc7a0..0309aab 100644
--- a/src/HAB/Pica/Record/Subfield.php
+++ b/src/HAB/Pica/Record/Subfield.php
@@ -23,7 +23,7 @@
*
* @package PicaRecord
* @author David Maus <maus@hab.de>
- * @copyright Copyright (c) 2012, 2013 by Herzog August Bibliothek Wolfenbüttel
+ * @copyright Copyright (c) 2012 - 2016 by Herzog August Bibliothek Wolfenbüttel
* @license http://www.gnu.org/licenses/gpl.html GNU General Public License v3
*/
@@ -33,6 +33,12 @@ use InvalidArgumentException;
class Subfield
{
+ /**
+ * Regular expression matching a valid subfield code.
+ *
+ * @var string
+ */
+ public static $validSubfieldCodePattern = '/^[a-z0-9]$/Di';
/**
* Return true if argument is a valid subfield code.
@@ -42,7 +48,7 @@ class Subfield
*/
public static function isValidSubfieldCode ($arg)
{
- return (bool)preg_match('/^[a-z0-9]$/Di', $arg);
+ return (bool)preg_match(self::$validSubfieldCodePattern, $arg);
}
/**
--
GitLab